-
Notifications
You must be signed in to change notification settings - Fork 5
Set up release workflow #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 83.26% 83.40% +0.13%
==========================================
Files 29 29
Lines 1661 1693 +32
==========================================
+ Hits 1383 1412 +29
- Misses 278 281 +3 🚀 New features to boost your workflow:
|
|
Yes, I would be very happy to test this out. |
|
I now realise that the release.yml added here is the YAML file mentioned, and identical with that in aclib. |
|
PR #81 has been merged, so when this is ready to go a release could be attempted. |
|
I have now created utils/.github/workflows/release.yml. |
|
Just realised how stupid that was, so will move the file to on e or more of my other packages. |
|
Am attempting a release of groupoids using this mechanism |
|
Release appears to have failed with: |
For usage instructions see https://github.com/gap-actions/release-pkg?tab=readme-ov-file#release-pkg
a902f3b to
dfa45fa
Compare
|
So, the idea was that you just merge this PR here and we try it out now. Anyway since you seem ok with it. I am doing that now. Next:
Indeed, we decided to become more strict because this kind of warning indicates a problem that maintainers should be aware of; previously in the CI such warnings were very easy to miss: if the CI passes / shows green, why would you look into the logs? You wouldn't, and so you'd miss the warning. But if you declare "this is fine, let those labels be missing!" you can override this and tell it to ignore the warnings. I've done that in - uses: gap-actions/build-pkg-docs@v2
with:
use-latex: true
warnings-as-errors: false
# Disable warnings as we we get errors triggered by the GAP
# reference manual and I have no idea what causes them or how to
# deal with them. E.g.:
#
# Section: "ref:specialpcgs" already defined as: 45.13.0
# Now being redefined as: 45.13.2
So you can just add that |
|
It was good that I was prompted to fix the Latex error, and that has now been done. |
|
@fingolfin - and the same error occurs when attempting to release IBNP-0.17. |
|
Have now reported these failures at: https://github.com/gap-actions/release-pkg/issues |
|
... and the problem has been fixed - both groupoids and IBNP now released - Utils is next! |
For usage instructions see https://github.com/gap-actions/release-pkg?tab=readme-ov-file#release-pkg
@cdwensley perhaps you'd be interested in using this (as successor for ReleaseTools).